Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes reverse proxy support in the Stellar SDK's Horizon client. Previously, only the initial request used the configured server URL, while subsequent pagination and linked resource requests used URLs from Horizon's _links responses, bypassing reverse proxies entirely.
Changes:
- Modified
CallBuilder._sendNormalRequest()to always replace URL authority and protocol with configured server values - Added integration test verifying pagination links use configured server URL
- Updated CHANGELOG with fix description
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/horizon/call_builder.ts | Removed conditional check, now always replaces authority and protocol in URLs to ensure all requests go through configured server |
| test/integration/client_headers.test.ts | Added comprehensive test simulating reverse proxy scenario with pagination |
| CHANGELOG.md | Documented the fix under "Unreleased" section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Size Change: -14.1 kB (-0.03%) Total Size: 45 MB
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
quietbits
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When using a reverse proxy, only the first request went through the proxy.
Subsequent requests (pagination via
.next(), linked resources) used URLsfrom Horizon's
_links, bypassing the proxy entirely.What
Always replace the authority and protocol of response URLs with the
configured server's values, instead of only when they're empty. From documentation it appears that the
_linkin Horizon responses should be all self referencing so always replacing should be safe.Summary
Horizon.ServerCloses #637